refactor(frontend): own Backdrop natively, detach from gix#13171
Draft
AntonioVentilii wants to merge 1 commit into
Draft
refactor(frontend): own Backdrop natively, detach from gix#13171AntonioVentilii wants to merge 1 commit into
AntonioVentilii wants to merge 1 commit into
Conversation
Bring gix Backdrop in-house as a native Svelte 5 OISY component. - New $lib/components/ui/Backdrop.svelte: runes; onClose callback replacing the createEventDispatcher 'nnsClose' event; keyboard via shared handleKeyPress; stopPropagation via the shared event-modifiers util; OISY i18n (core.text.close) - Fold the gix.scss --backdrop-contrast/--backdrop-filter values into the component; keep using OISY's own --backdrop (variables.scss). The gix.scss :root definitions stay for now since gix Popover still renders a backdrop; they'll be removed in the final cleanup. - Rewire the 5 direct Backdrop consumers (Popover-based ones migrate with Popover) No new deps, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of detaching OISY from
@dfinity/gix-components(now maintenance-mode).Backdropin-housed as a native OISY component. Stacked on #13163.Changes
$lib/components/ui/Backdrop.svelte: native Svelte 5;onClosecallback replacing the gixnnsCloseevent;handleKeyPress+stopPropagationfrom the shared utils; OISY i18n (core.text.close).gix.scss--backdrop-contrast/--backdrop-filtervalues into the component; keep OISY's own--backdrop(variables.scss). Thegix.scss:rootdefs are intentionally left for now — gixPopoverstill renders a backdrop that needs them; they'll go in the final cleanup.Tests
lint --max-warnings 0clean;checkclean (only the pre-existing unrelatedsol-instructions-systemerror)