Fix accessibility: add missing labels to fundraising SVG and images#2553
Open
Mr-Sunglasses wants to merge 1 commit intodjango:mainfrom
Open
Fix accessibility: add missing labels to fundraising SVG and images#2553Mr-Sunglasses wants to merge 1 commit intodjango:mainfrom
Mr-Sunglasses wants to merge 1 commit intodjango:mainfrom
Conversation
erosselli
reviewed
Mar 15, 2026
erosselli
left a comment
erosselli
left a comment
There was a problem hiding this comment.
Thanks for contributing! I left some comments
Comment on lines
3
to
+4
| <div class="hero-logo"> | ||
| {% if obj.url %}<a href="{{ obj.url }}" rel="nofollow">{% endif %} | ||
| {% if obj.url %}<a href="{{ obj.url }}" rel="nofollow" aria-label="{{ obj.display_name }}">{% endif %} |
There was a problem hiding this comment.
what is this change? It seems unrelated to the heart image
|
|
||
| <div class="fundraising-heart" data-percent="{{ goal_percent }}"> | ||
| <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 503 431"> | ||
| <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 503 431" role="img" aria-label="{% blocktranslate trimmed %}Fundraising progress: {{ goal_percent }} funded{% endblocktranslate %}"> |
There was a problem hiding this comment.
I think this needs a "%", since right now it reads "Fundraising progress: 0 funded" which to me seems like an absolute number rather than a %
Suggested change
| <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 503 431" role="img" aria-label="{% blocktranslate trimmed %}Fundraising progress: {{ goal_percent }} funded{% endblocktranslate %}"> | |
| <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 503 431" role="img" aria-label="{% blocktranslate trimmed %}Fundraising progress: {{ goal_percent }} percent funded{% endblocktranslate %}"> |
|
|
||
| <div class="fundraising-heart" data-percent="{{ goal_percent }}"> | ||
| <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 503 431"> | ||
| <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 503 431" role="img" aria-label="{% blocktranslate trimmed %}Fundraising progress: {{ goal_percent }} funded{% endblocktranslate %}"> |
There was a problem hiding this comment.
also since this is new text, I think we might need to add this as new messages to locale/en/LC_MESSAGES/django.po -- look at how we do it for the existing {{ goal_percent }}% funded text :)
| </g> | ||
| <foreignObject> | ||
| <img src="{% static 'img/fundraising-heart.svg' %}" /> | ||
| <img src="{% static 'img/fundraising-heart.svg' %}" alt="{% translate 'Fundraising heart logo' %}" /> |
There was a problem hiding this comment.
is this needed? I tested with a screen reader and this doesn't get read out but I tbh I think just the label from above is enough
Member
|
@Mr-Sunglasses Do you plan to address the comments here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #2552
Before:
After: