Skip to content

Fix accessibility: add missing labels to fundraising SVG and images #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Sunglasses wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fix accessibility: add missing labels to fundraising SVG and images #2553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion djangoproject/templates/fundraising/includes/_hero_with_logo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% load i18n static thumbnail %}
<div class="hero">
<div class="hero-logo">
{% if obj.url %}<a href="{{ obj.url }}" rel="nofollow">{% endif %}
{% if obj.url %}<a href="{{ obj.url }}" rel="nofollow" aria-label="{{ obj.display_name }}">{% endif %}
Comment on lines 3 to +4
Copy link
Copy Markdown

@erosselli erosselli Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this change? It seems unrelated to the heart image

{% if obj.logo %}
<img
src="{{ obj.thumbnail.url }}"
Expand Down
4 changes: 2 additions & 2 deletions djangoproject/templates/fundraising/includes/donation_form_with_heart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div class="fundraising-index" id="donate">

<div class="fundraising-heart" data-percent="{{ goal_percent }}">
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 503 431">
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 503 431" role="img" aria-label="{% blocktranslate trimmed %}Fundraising progress: {{ goal_percent }} funded{% endblocktranslate %}">
Copy link
Copy Markdown

@erosselli erosselli Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a "%", since right now it reads "Fundraising progress: 0 funded" which to me seems like an absolute number rather than a %

Suggested change
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 503 431" role="img" aria-label="{% blocktranslate trimmed %}Fundraising progress: {{ goal_percent }} funded{% endblocktranslate %}">
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 503 431" role="img" aria-label="{% blocktranslate trimmed %}Fundraising progress: {{ goal_percent }} percent funded{% endblocktranslate %}">

Copy link
Copy Markdown

@erosselli erosselli Mar 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also since this is new text, I think we might need to add this as new messages to locale/en/LC_MESSAGES/django.po -- look at how we do it for the existing {{ goal_percent }}% funded text :)

<switch>
<g>
<g transform="translate(4, 2)" id="pixels">
Expand All @@ -13,7 +13,7 @@
<text x="50%" y="43%" alignment-baseline="middle" text-anchor="middle">{{ goal_percent|floatformat:'0' }}%</text>
</g>
<foreignObject>
<img src="{% static 'img/fundraising-heart.svg' %}" />
<img src="{% static 'img/fundraising-heart.svg' %}" alt="{% translate 'Fundraising heart logo' %}" />
Copy link
Copy Markdown

@erosselli erosselli Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? I tested with a screen reader and this doesn't get read out but I tbh I think just the label from above is enough

</foreignObject>
</switch>
</svg>
Expand Down