Conversation
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22903" |
Yep, that's a bug fix and a breaking change, will require either an edition guard or a deprecation. |
|
Glad to see this hole finally getting patched! |
e35535d to
22383a6
Compare
|
Test suite looking good, ping me when this is good to go. |
|
So I marked this PR as a refactor, switching from inlineCopy + resolveLoc to syntaxCopy + expressionSemantic. In more detail:
This means less class boilerplate, not having a separate visit pass for if (sc.inDefaultArg || sc.callLoc.isValid)
return false;In a follow up PR I plan to replace these with actual deprecation / edition logic to fix the bug, and add a test and changelog. If this all sounds good, it's ready to merge @thewilsonator |
|
I'll leave it to you to squash or rebase and merge as you see fit. |
Big PR, will split off parts but first see how test suite reacts.
Probably fixes (edit: not yet) #18670 (needs tests), supersedes #14309