Add wasm and core cl rr2r builds to per commit builds#5191
Open
LoopedBard3 wants to merge 2 commits intodotnet:mainfrom
Open
Add wasm and core cl rr2r builds to per commit builds#5191LoopedBard3 wants to merge 2 commits intodotnet:mainfrom
LoopedBard3 wants to merge 2 commits intodotnet:mainfrom
Conversation
Add dispatch entry for coreclr_r2r_interpreter in runtime-perf-build-jobs.yml to route the new build type to perf-coreclr-build-jobs.yml. The wasm_coreclr build type is already handled by the existing wasm entry which unconditionally builds both mono and coreclr wasm variants. Add upload entries for both wasm_coreclr and coreclr_r2r_interpreter in upload-build-artifacts-jobs.yml so their build artifacts are uploaded to blob storage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The perf-wasm-build-jobs.yml template builds both mono wasm and coreclr wasm variants unconditionally. Previously only the 'wasm' buildType triggered it, so passing 'wasm_coreclr' alone would skip the build entirely. Use or() to trigger on either buildType. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates pipeline dispatching and artifact uploads so new per-commit build types (wasm_coreclr and coreclr_r2r_interpreter) are correctly built and have their outputs published to blob storage.
Changes:
- Route
wasm_coreclrbuild requests through the existing wasm build job template dispatch. - Add dispatch entry for
coreclr_r2r_interpreterbuilds to the CoreCLR build job template. - Add upload steps for
wasm_coreclrandcoreclr_r2r_interpreterartifacts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/runtime-perf-build-jobs.yml | Adds build-type dispatch for wasm_coreclr and coreclr_r2r_interpreter so the right build templates run. |
| eng/pipelines/upload-build-artifacts-jobs.yml | Adds artifact upload jobs for BrowserWasmCoreCLR and BuildArtifacts_linux_x64_Release_coreclr_r2r_interpreter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dispatch entry for coreclr_r2r_interpreter in runtime-perf-build-jobs.yml to route the new build type to perf-coreclr-build-jobs.yml. The wasm_coreclr build type is already handled by the existing wasm entry which unconditionally builds both mono and coreclr wasm variants.
Add upload entries for both wasm_coreclr and coreclr_r2r_interpreter in upload-build-artifacts-jobs.yml so their build artifacts are uploaded to blob storage.
In another PR, the wasm build jobs should be split up to be buildable with specific parameters for the exact build to build defined.
Should be merged with: dotnet/runtime#126589
Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2944775&view=results