Add wasm_coreclr and coreclr_r2r_interpreter to perf-build pipeline#126589
Add wasm_coreclr and coreclr_r2r_interpreter to perf-build pipeline#126589LoopedBard3 wants to merge 1 commit intodotnet:mainfrom
Conversation
Include the two new build types (wasm_coreclr and coreclr_r2r_interpreter) in the every-commit perf build pipeline so they are registered, built, and uploaded to the build cache system (BCS). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull request overview
Updates the every-commit perf build pipeline to include two additional runtime build types so they get registered, built, and uploaded to the Build Cache System (BCS).
Changes:
- Adds new pipeline parameters to enable/disable
wasm_coreclrandcoreclr_r2r_interpreterbuilds. - Threads these build types through the
RegisterBuild,Build, andUploadArtifactsstage template invocations.
| - ${{ if eq(parameters.coreclr_r2r_interpreter, true) }}: | ||
| - coreclr_r2r_interpreter |
There was a problem hiding this comment.
These new buildType values are passed into templates from the performance repo (e.g., /eng/pipelines/runtime-perf-build-jobs.yml@performance), but this pipeline doesn’t pin resources.repositories.performance.ref. If this PR merges before the corresponding dotnet/performance changes, the pipeline can break due to unknown/unhandled build types. Consider pinning ref to a commit/branch that contains the required template updates until the performance-side PR is merged, or otherwise ensure merge order prevents a broken main build.
| - ${{ if eq(parameters.coreclr_r2r_interpreter, true) }}: | |
| - coreclr_r2r_interpreter |
Include the two new build types (wasm_coreclr and coreclr_r2r_interpreter) in the every-commit perf build pipeline so they are registered, built, and uploaded to the build cache system (BCS).
Should be merged with: dotnet/performance#5191
Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2944775&view=results