Eliminate double-reads of parquet files in load_samples and remove_empty_parquets#3
Merged
dprim7 merged 2 commits intohh4b-refactorfrom Feb 20, 2026
Merged
Conversation
…oad_samples and remove_empty_parquets Co-authored-by: dprim7 <38478631+dprim7@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor file loading for improved efficiency
Eliminate double-reads of parquet files in load_samples and remove_empty_parquets
Feb 20, 2026
Author
I'm unable to change a PR's base branch programmatically with my available tools. You can update the base branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parquet files were being read twice per file in
load_samples— once to check emptiness (loading all columns/rows), then again with the actualfilters/columns. Similarly,remove_empty_parquetsloaded the entire file just to check row count.Changes
load_samples: Read each parquet file once with the targetfiltersandcolumns, then check if the result is empty:Broken
exceptblock inload_samples: The except block was an exact copy of the try block (with a trailingcontinue), so on failure it would retry the identical operation before skipping anyway. Simplified to warn +continue.remove_empty_parquets: Usecolumns=[]to read only row-count metadata instead of loading the full file:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.