Skip to content

Eliminate double-reads of parquet files in load_samples and remove_empty_parquets #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dprim7 merged 2 commits into from
Feb 20, 2026
Merged

Eliminate double-reads of parquet files in load_samples and remove_empty_parquets #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ccc384
Initial plan
Copilot Feb 20, 2026
977b449
Fix inefficient file loading: avoid double-reading parquet files in l…
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions src/HH4b/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def remove_empty_parquets(samples_dir, year):
parquet_files = listdir(f"{samples_dir}/{year}/{sample}/parquet")
for f in parquet_files:
file_path = f"{samples_dir}/{year}/{sample}/parquet/{f}"
if not len(pd.read_parquet(file_path)):
if not len(pd.read_parquet(file_path, columns=[])):
print("Removing: ", f"{sample}/{f}")
Path(file_path).unlink()

Expand Down Expand Up @@ -367,24 +367,16 @@ def load_samples(
try:
non_empty_passed_list = []
for parquet_file in parquet_path.glob("*.parquet"):
if not pd.read_parquet(parquet_file).empty:
df_sample = pd.read_parquet(
parquet_file, filters=filters, columns=load_columns
)
df_sample = pd.read_parquet(
parquet_file, filters=filters, columns=load_columns
)
if not df_sample.empty:
non_empty_passed_list.append(df_sample)
events = pd.concat(non_empty_passed_list, ignore_index=True)
except Exception:
warnings.warn(
f"Can't read file with requested columns/filters for {sample}!", stacklevel=1
)
non_empty_passed_list = []
for parquet_file in parquet_path.glob("*.parquet"):
if not pd.read_parquet(parquet_file).empty:
df_sample = pd.read_parquet(
parquet_file, filters=filters, columns=load_columns
)
non_empty_passed_list.append(df_sample)
events = pd.concat(non_empty_passed_list, ignore_index=True)
continue

# no events?
Expand Down
Loading