fix(synology): replace readNBytes with Guava ByteStreams.read#1489
Merged
mengyushen merged 2 commits intodtinit:masterfrom Apr 7, 2026
Merged
Conversation
## Goal The goal of this change is to improve compatibility of chunked reading in by replacing the Java 9+ method with Guava's , ensuring the code works correctly in older Java environments. ## Changes - **Dependency Update:** Added `com.google.guava:guava` to the Synology extension's `build.gradle`. - **Code Refactor:** Updated `SynologyDTPService` to use `ByteStreams.read` when reading video chunks.
mengyushen
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this change is to improve compatibility of chunked reading in
by replacing the Java 9+ method with Guava's
, ensuring the code works correctly in older Java environments.
Changes
com.google.guava:guavato the Synology extension'sbuild.gradle.SynologyDTPServiceto useByteStreams.readwhen reading video chunks.