Skip to content

fix(synology): replace readNBytes with Guava ByteStreams.read #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mengyushen merged 2 commits into from
Apr 7, 2026
+3 −1
Merged

fix(synology): replace readNBytes with Guava ByteStreams.read #1489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feaf1d0
fix(synology): replace readNBytes with Guava ByteStreams.read
simonxander Apr 6, 2026
4e056f4
Merge branch 'master' into synology-remote-read-n-bytes
mengyushen Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/data-transfer/portability-data-transfer-synology/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ dependencies {
compile project(':portability-spi-cloud')
compile project(':portability-transfer')
compile "com.squareup.okhttp3:okhttp:${okHttpVersion}"
compile "com.google.guava:guava:${guavaVersion}"
}

configurePublication(project)
3 changes: 2 additions & 1 deletion ...c/main/java/org/datatransferproject/datatransfer/synology/service/SynologyDTPService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Strings;
import com.google.common.io.ByteStreams;
import java.io.IOException;
import java.io.InputStream;
import java.net.URL;
Expand Down Expand Up @@ -276,7 +277,7 @@ private int uploadVideoChunks(VideoModel video, UUID jobId, InputStream inputStr
// since we are uploading in sequential, there is no concurrency issue
byte[] chunkData = new byte[CHUNK_SIZE];
while (true) {
int bytesRead = inputStream.readNBytes(chunkData, 0, CHUNK_SIZE);
int bytesRead = ByteStreams.read(inputStream, chunkData, 0, CHUNK_SIZE);
if (bytesRead == 0) {
break;
}
Expand Down
Loading