Fix VichImageTypeTest failing with LiipImagine enabled - #1580
Merged
Conversation
theredled
marked this pull request as ready for review
March 3, 2026 18:17
garak
requested changes
Mar 4, 2026
garak
left a comment
garak
left a comment
Collaborator
There was a problem hiding this comment.
We should enable the option in the build, right?
Contributor
Author
If you're talking about the |
Collaborator
|
So, what we need to fix in the PR 1579 is different from this change? |
Contributor
Author
|
PR 1579 is only adding tests to the CI. |
Collaborator
We can't only add failing tests, we need to fix them in the same PR |
Contributor
Author
Ok, merged PR 1579 into this one. |
Contributor
Author
|
Test Fail #4 (#1578 (comment)) seems to be a config issue on my side, so all tests should pass now. |
garak
approved these changes
Mar 4, 2026
Contributor
Author
|
Hourray |
Copilot AI
added a commit
that referenced
this pull request
Apr 11, 2026
Ported changes: - Fix translation for 'delete_label' when 'download_label' is a callable (#1574) - Fix VichImageTypeTest failing with LiipImagine enabled (#1580) - Add test with LiipImagine enabled in CI - Fix coding standard (Dockerfile85, static fn) - Document Gedmo/DoctrineExtensions issue (#1582) - Update directory_namer service id in doc - Extract TestCaseTrait for reuse across test base classes - Fix Product::getImage() return type Skipped (not applicable to 3.x): - XML to PHP config migration (already done) - Annotation deprecation layer (3.x removed annotations) - Allow Symfony 8 (3.x already supports it) - BypassFinal fix (not used in 3.x) Agent-Logs-Url: https://github.com/dustin10/VichUploaderBundle/sessions/94f40c3f-9548-4dcc-afd3-c04655b22ed2 Co-authored-by: garak <179866+garak@users.noreply.github.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests fail (x4) with LiipImagine enabled : #1578
Fixing 3 of them (false negative) by removing obsolete "show_download_link" view var in
VichImageTypeTest