Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8b0e7a2
Make bnn_pynq end2end tests parallelizable
fpjentzsch Feb 7, 2025
308f885
Make notebook and remaining end2end tests parallelizable
fpjentzsch Feb 7, 2025
6bd073a
[Notebooks] Replace disutil copy_tree with shutil in notebooks
auphelia Feb 7, 2025
1cb5877
Merge pull request #1268 from eki-project/fix/copytree
auphelia Feb 7, 2025
ee0943a
Use unique Netron port for each notebook xdist group
fpjentzsch Feb 11, 2025
15c6e38
[Lookup] Test data should also be read as float32 container type
iksnagreb Feb 14, 2025
20e0c2b
[Concat] Remove instream width padded duplicate
auphelia Feb 19, 2025
ff38e04
[ci] Update Jenkinsfile build artifact gathering
jmonks-amd Feb 19, 2025
e60694d
[ci] Run fpgadataflow in parallel
jmonks-amd Feb 19, 2025
78c23a5
Merge pull request #1279 from Xilinx/testing/jenkinsfile_updates
auphelia Feb 20, 2025
f1c88cf
Merge remote-tracking branch 'upstream/dev' into fix/finn_docker_tag
auphelia Feb 20, 2025
e486c03
Merge pull request #1182 from iksnagreb/fix/finn_docker_tag
auphelia Feb 20, 2025
e65da62
Merge remote-tracking branch 'upstream/dev' into fix/lookup
auphelia Feb 20, 2025
88053fd
Merge remote-tracking branch 'upstream/dev' into deps/pyyaml
auphelia Feb 20, 2025
a471350
Merge pull request #966 from iksnagreb/deps/pyyaml
auphelia Feb 20, 2025
32fbff0
[LookUp] With npy type being float we can use parent class method for…
auphelia Feb 20, 2025
76eede6
Merge pull request #1267 from iksnagreb/fix/lookup
auphelia Feb 20, 2025
05a22bd
Merge remote-tracking branch 'upstream/dev' into fix/tests_parallelis…
auphelia Feb 20, 2025
cbf3636
Merge pull request #1273 from eki-project/fix/tests_parallelism_safe
auphelia Feb 21, 2025
706ce54
Remove obsolete copy of Q_srl implementation.
preusser Feb 25, 2025
9d7989b
Raise error for FIFO depth smaller than two.
preusser Feb 25, 2025
2b55849
Ensuring that Q_srl RTL style FIFOs never have a depth of 1 when spli…
STFleming Feb 26, 2025
4788ebe
Updated the tests to check for a fifo size that was previously splitt…
STFleming Feb 26, 2025
dcb7177
Amended split_large_fifo_config tests to account for new fifo depths
STFleming Feb 26, 2025
10bf54b
Merge pull request #1284 from Xilinx/preusser/q_srl_guard
auphelia Feb 26, 2025
94f887b
[InsertFIFOs] Ensure that depth 1 FIFOs are at least depth 2 if creat…
auphelia Mar 1, 2025
d86ec13
[Thresholding] Generalize data layouts for node execution
iksnagreb Mar 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions docker/jenkins/Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ pipeline {
cleanPreviousBuildFiles(env.FINN_HOST_BUILD_DIR)

// Pass in the marker to run with pytest and the XML test results filename
runDockerPytestWithMarker("fpgadataflow", "${env.TEST_NAME}", "--cov --cov-report=html:coverage_fpgadataflow")
runDockerPytestWithMarker("fpgadataflow", "${env.TEST_NAME}", "--cov --cov-report=html:coverage_fpgadataflow -n ${env.NUM_PYTEST_WORKERS} --dist worksteal")

// Stash the test results file(s)
stash name: env.TEST_NAME, includes: "${env.TEST_NAME}.xml,${env.TEST_NAME}.html"
Expand Down Expand Up @@ -324,21 +324,17 @@ void runDockerPytestWithMarker(String marker, String testResultsFilename, String
sh """./run-docker.sh python -m pytest -m ${marker} --junitxml=${testResultsFilename}.xml --html=${testResultsFilename}.html --self-contained-html ${additionalOptions}"""
}

def findBoardBuildFiles(String searchDir, String dirToFind) {
def result = sh(script: "find $searchDir -type d -name \"$dirToFind*\"", returnStdout: true).trim()
if (result.empty) {
error "Directory containing '$dirToFind' not found."
}
return result
}

void findCopyZip(String board, String findDir, String copyDir) {
def buildDir = findBoardBuildFiles(findDir, "hw_deployment_${board}")
sh "cp -r ${buildDir}/${board} ${copyDir}/"
dir(copyDir) {
sh "zip -r ${board}.zip ${board}/"
sh "mkdir -p ${env.ARTIFACT_DIR}/${copyDir}/"
sh "cp ${board}.zip ${env.ARTIFACT_DIR}/${copyDir}/"
sh "mkdir -p ${copyDir}"
try {
sh "cp -r ${findDir}/hw_deployment_*/${board} ${copyDir}/"
dir(copyDir) {
sh "zip -r ${board}.zip ${board}/"
sh "mkdir -p ${env.ARTIFACT_DIR}/${copyDir}/"
sh "cp ${board}.zip ${env.ARTIFACT_DIR}/${copyDir}/"
}
} catch (err) {
error "No ${board} hw_deployment_* build artifacts found in ${findDir}"
}
}

Expand Down
9 changes: 9 additions & 0 deletions finn-rtllib/fifo/hdl/Q_srl.v
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,15 @@ module Q_srl (clock, reset, i_d, i_v, i_r, o_d, o_v, o_r, count, maxcount);
reg i_b_reg // - true iff !full
/* synthesis syn_allow_retiming=0 */ ;

// Parameter Checking
initial begin
if(depth < 2) begin
$error("%m: FIFO depth must be two or higher.");
$finish;
end
end


assign addr_full_ = (state_==state_more) && (addr_==depth-2);
// - queue full
assign addr_zero_ = (addr==0); // - queue contains 2 (or 1,0)
Expand Down
308 changes: 0 additions & 308 deletions finn-rtllib/memstream/hdl/Q_srl.v

This file was deleted.

5 changes: 2 additions & 3 deletions notebooks/end2end_example/bnn-pynq/cnv_end2end_example.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -484,8 +484,7 @@
"metadata": {},
"outputs": [],
"source": [
"from shutil import copy\n",
"from distutils.dir_util import copy_tree\n",
"from shutil import copy, copytree\n",
"\n",
"# create directory for deployment files\n",
"deployment_dir = make_build_dir(prefix=\"pynq_deployment_\")\n",
Expand All @@ -503,7 +502,7 @@
"\n",
"# driver.py and python libraries\n",
"pynq_driver_dir = model.get_metadata_prop(\"pynq_driver_dir\")\n",
"copy_tree(pynq_driver_dir, deployment_dir)"
"copytree(pynq_driver_dir, deployment_dir, dirs_exist_ok=True)"
]
},
{
Expand Down
Loading