Fix crash on Windows/macOS when keychain access is denied - #34922
Draft
kaylendog wants to merge 1 commit into
Draft
Fix crash on Windows/macOS when keychain access is denied#34922kaylendog wants to merge 1 commit into
kaylendog wants to merge 1 commit into
Conversation
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
kaylendog
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
safeStorage.getSelectedStorageBackendis Linux-only but it's called unconditionally here, which crashes whenever access to the system keychain is denied on macOS (and probably Windows too, but I don't have a Windows machien to test that hypothesis on).Minor issuse with tiny fix I encountered while working on Yubikey support. Not really sure if it's testable programatically?
Checklist
public/exportedsymbols have accurate TSDoc documentation.