Skip to content

Fix crash on Windows/macOS when keychain access is denied #34922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kaylendog wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix crash on Windows/macOS when keychain access is denied #34922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/desktop/src/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,9 @@
title: _t("store|error|backend_no_encryption_title"),
message: _t("store|error|backend_no_encryption"),
detail: _t("store|error|backend_no_encryption_detail", {
backend: safeStorage.getSelectedStorageBackend(),
// getSelectedStorageBackend is Linux-only; elsewhere the backend we failed to use is the system keychain
// See https://www.electronjs.org/docs/latest/api/safe-storage#safestoragegetselectedstoragebackend-linux
backend: process.platform === "linux" ? safeStorage.getSelectedStorageBackend() : "system",

Check warning on line 399 in apps/desktop/src/store.ts

View workflow job for this annotation

GitHub Actions / Tests

Uncovered Line 

Line 399 is not covered by tests
brand: getConfig().brand,
}),
type: "error",
Expand Down
Loading