Don't sanitize URI on drop#894
Merged
Merged
Conversation
Collaborator
|
We need to fix DnD in Files before this can be merged - otherwise truncation still occurs when testing with Files. |
jeremypw
approved these changes
Aug 14, 2025
jeremypw
left a comment
jeremypw
left a comment
Collaborator
There was a problem hiding this comment.
Fixes the issue for Dolphin and Nautilus. Needs to be fixed in Files itself. Thanks!
Collaborator
|
Not sure why CI fails - passes OK locally. |
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #876
Closes #877
URIs must escape special characters and Utils.sanitize_path undoes this. Furthermore, there's no other reasons to use Utils.sanitize_path here -- dropped paths must be absolute. So in conclusion if a file manager does everything correctly, we shouldn't need this. I tested this branch using Dolphin.