Skip to content

Don't sanitize URI on drop #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremypw merged 3 commits into from
Aug 14, 2025
Merged

Don't sanitize URI on drop #894

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5f39e4
Don't sanitize URI on drop
lenemter Aug 11, 2025
3c30341
Merge branch 'master' into lenemter/dnd-dont-sanitize-path
lenemter Aug 11, 2025
65ca99c
Merge branch 'master' into lenemter/dnd-dont-sanitize-path
jeremypw Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/Widgets/TerminalWidget.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,6 @@ namespace Terminal {
case DropTargets.URILIST:
var uris = selection_data.get_uris ();
string path;
File file;
for (var i = 0; i < uris.length; i++) {
// Get unquoted path as some apps may drop uris that are escaped
// and quoted.
Expand All @@ -846,10 +845,10 @@ namespace Terminal {
warning ("Error unquoting %s. %s", uris[i], e.message);
unquoted_uri = uris[i];
}
// Sanitize the path as we do not want the `file://` scheme included
// and we assume dropped paths are absolute.
file = File.new_for_uri (Utils.sanitize_path (unquoted_uri, "", false));
path = file.get_path ();

// Get path as we do not want the `file://` scheme included
// and we assume dropped paths are absolute so no need for Utils.sanitize_path
path = File.new_for_uri (unquoted_uri).get_path ();
if (path != null) {
uris[i] = Shell.quote (path) + " ";
} else {
Expand Down