fix: Time-of-check Time-of-use bug in session management#1375
Merged
Conversation
ghislainbourgeois
force-pushed
the
fix-toctou
branch
4 times, most recently
from
June 1, 2026 19:15
7060001 to
376ca31
Compare
ghislainbourgeois
force-pushed
the
fix-toctou
branch
from
June 1, 2026 19:40
376ca31 to
d62a3c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an time-of-check/time-of-use bug in session management, that could potentially lead to a double-free on IP addresses. It was very unlikely to be triggered, and the tests to cover this would be too complex, so I did not add them.
Checklist: