Skip to content

fix: Time-of-check Time-of-use bug in session management #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghislainbourgeois merged 1 commit into from
Jun 1, 2026
Merged

fix: Time-of-check Time-of-use bug in session management #1375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/smf/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func (s *SMF) CreateSmContext(ctx context.Context, supi etsi.SUPI, pduSessionID
}
}
smContext.Mutex.Unlock()
s.RemoveSession(ctx, smContext.CanonicalName())
s.removeSessionUnlocked(ctx, smContext.CanonicalName())
}
}()

Expand Down
10 changes: 5 additions & 5 deletions internal/smf/release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ func (s *SMF) ReleaseSmContext(ctx context.Context, smContextRef string) error {
if err != nil {
span.RecordError(err)
span.SetStatus(codes.Error, "failed to release tunnel")
s.removeSessionUnlocked(ctx, smContextRef)

return fmt.Errorf("release tunnel failed: %v", err)
}

s.removeSessionUnlocked(ctx, smContextRef)
// Remove from pool under lock after all network I/O is complete.
s.mu.Lock()
delete(s.pool, smContextRef)
s.mu.Unlock()

return nil
return err
}

// releaseTunnel deactivates the GTP data path and sends a PFCP deletion request.
Expand Down
Loading