Open
Conversation
DeboBurro
reviewed
Jan 9, 2023
DeboBurro
left a comment
There was a problem hiding this comment.
we have this issue too. discussed as well in StackOverflow
File "/root/catkin_ws/install/lib/python3/dist-packages/ros_numpy/point_cloud2.py", line 224, in <module>
def get_xyz_points(cloud_array, remove_nans=True, dtype=np.float):
File "/root/.local/lib/python3.8/site-packages/numpy/__init__.py", line 284, in __getattr__
raise AttributeError("module {!r} has no attribute "
AttributeError: module 'numpy' has no attribute 'float'
The only thing I am not sure about here is that should be float64 or float32?
|
We have this issue too. Would be great to get it fixed! |
To my knowledge, the points in PointCloud2 are of type |
|
Isn't this issues solved since #39 was merged? |
|
@gstavrinos is it possible please to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest numpy release deprecates
np.float, see: https://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecationsThis MR aims to solve this deprecation issue by replacing
np.floatbynp.float32.