Fix SSMS extension version targeting so the gallery shows SSMS 21/22 (#370)#371
Merged
Merged
Conversation
…370) The InstallationTarget version under Microsoft.VisualStudio.Ssms is the SSMS product version, not the VS shell version. The old [17.0,) installed fine (21 and 22 are both >= 17) but the SSMS Gallery rendered the lower bound literally as "Supports SSMS 17 SSMS 18". Switch to [21.0,23.0) (the form ErikEJ's SqlCeToolbox uses) so the gallery shows "SSMS 21 / SSMS 22", and clarify the description. Verified end to end: rebuilt the VSIX and confirmed SSMS 22's VSIXInstaller accepts [21.0,23.0) (uninstall + reinstall both exit 0). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #370.
The
InstallationTargetversion underMicrosoft.VisualStudio.Ssmsis the SSMS product version, not the VS shell version. The previous[17.0,)installed fine (SSMS 21/22 are both >= 17) but the SSMS Gallery rendered the lower bound literally as "Supports SSMS 17 SSMS 18". This switches to[21.0,23.0)— the form ErikEJ's SqlCeToolbox uses — so the gallery shows "SSMS 21 / SSMS 22", and clarifies the<Description>.Confirmed with @ErikEJ (gallery maintainer) on the issue thread.
Test plan
[21.0,23.0)is in the packagedextension.vsixmanifest.[21.0,23.0).Version=[21.0,23.0)for both amd64 and arm64.🤖 Generated with Claude Code