Vehicle: test feature param consistency for shared include#31321
Merged
Conversation
Every online vehicle exposes climaterdisabled and autodetectdisabled via the vehicle-features include, so a stored config may carry them. If a template renders the include but no longer declares the param, reloading that config fails with "invalid key" (discussion #31291). Add a test asserting both toggles stay declared on every template using the include. It surfaced that autodetectdisabled was still undeclared on offline and iso15118 - the same class as the climaterdisabled fix in #31297 - so restore it there as a deprecated param.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #31306
Online vehicles expose
climaterdisabledandautodetectdisabledthrough the sharedvehicle-featuresinclude, so a stored configuration can carry either key. When a template renders the include but no longer declares the matching param, reloading that configuration fails withinvalid keyand the vehicle no longer starts. DB-only setups are hit hardest, since the affected vehicles disappear from the UI. This is what broke offline vehicles in discussion #31291.This adds a test asserting both toggles stay declared params on every vehicle template that renders the include. The test immediately surfaced that
autodetectdisabledwas still undeclared on theofflineandiso15118templates, the same defect class that #31297 fixed forclimaterdisabled. Both are restored as deprecated params so existing configurations keep validating, following the deprecate, never remove rule.🤖 Generated with Claude Code