Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions templates/definition/vehicle/iso15118.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ params:
- preset: vehicle-common
- name: climaterdisabled
deprecated: true
- name: autodetectdisabled
deprecated: true
render: |
type: custom
{{ include "vehicle-common" . }}
Expand Down
2 changes: 2 additions & 0 deletions templates/definition/vehicle/offline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ params:
- name: welcomecharge
- name: climaterdisabled
deprecated: true
- name: autodetectdisabled
deprecated: true
render: |
type: custom
{{- include "vehicle-common" . }}
Expand Down
23 changes: 23 additions & 0 deletions vehicle/template_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package vehicle

import (
"strings"
"testing"

"github.com/evcc-io/evcc/api"
Expand Down Expand Up @@ -40,3 +41,25 @@ func TestTemplates(t *testing.T) {
}
})
}

// universalVehicleFeatures render via the shared vehicle-features include, so a
// stored config may carry them; dropping the param breaks reload (discussion #31291).
var universalVehicleFeatures = []string{"climaterdisabled", "autodetectdisabled"}

func TestVehicleFeatureParamsConsistent(t *testing.T) {
for _, tmpl := range templates.ByClass(templates.Vehicle, templates.WithDeprecated()) {
if !strings.Contains(tmpl.Render, "vehicle-features") {
continue
}

for _, feat := range universalVehicleFeatures {
values := tmpl.Defaults(templates.RenderModeUnitTest)
values["template"] = tmpl.Template
values[feat] = true

if _, _, err := tmpl.RenderResult(templates.RenderModeInstance, values); err != nil {
t.Errorf("%s: feature %q must stay a declared param: %v", tmpl.Template, feat, err)
}
}
}
}
Loading