Adopt shared Scala CI workflow - #244
Conversation
📝 WalkthroughWalkthroughThe CI job now delegates to a reusable workflow for Scala 2.13.18 and 3.3.7. Scalafmt checks are disabled. The project replaces ChangesCI modernization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
13-14: 📐 Maintainability & Code Quality | 🔵 TrivialResolve the disabled formatting check.
scalafmt_check: falseleaves formatting unvalidated. The TODO is also reported by SonarCloud. Add the requiredsbt-scalafmtconfiguration and enable the check, or track the omission in an issue and remove the TODO. I can prepare the formatter configuration.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 13 - 14, Resolve the disabled scalafmt_check configuration in the CI workflow by adding the required sbt-scalafmt setup and enabling formatting validation; alternatively, create a tracking issue for the omission and remove the TODO comment. Ensure the workflow no longer silently skips formatting checks.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 12: Update the scala_versions matrix entry to use Scala 3.3.8 instead of
3.3.7, while preserving the existing Scala 2.13.18 value.
---
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 13-14: Resolve the disabled scalafmt_check configuration in the CI
workflow by adding the required sbt-scalafmt setup and enabling formatting
validation; alternatively, create a tracking issue for the omission and remove
the TODO comment. Ensure the workflow no longer silently skips formatting
checks.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9b9a2d8e-b397-49f1-bd47-dae94116c892
📒 Files selected for processing (2)
.github/workflows/ci.ymlproject/plugins.sbt
💤 Files with no reviewable changes (1)
- project/plugins.sbt
| url: ${{ secrets.SLACK_WEBHOOK }} | ||
| uses: evolution-gaming/scala-github-actions/.github/workflows/ci.yml@dde27b9bd793d41d5aacf8fb74403c9de5da1146 # v6.3.0 | ||
| with: | ||
| scala_versions: '["2.13.18", "3.3.7"]' |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Test the declared Scala 3.3 cross-build version.
build.sbt declares Scala 3.3.8, but this workflow tests 3.3.7. CI can pass while the supported Scala 3.3.8 target fails. Change this value to 3.3.8.
Proposed fix
- scala_versions: '["2.13.18", "3.3.7"]'
+ scala_versions: '["2.13.18", "3.3.8"]'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| scala_versions: '["2.13.18", "3.3.7"]' | |
| scala_versions: '["2.13.18", "3.3.8"]' |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/ci.yml at line 12, Update the scala_versions matrix entry
to use Scala 3.3.8 instead of 3.3.7, while preserving the existing Scala 2.13.18
value.
2 participants
Replaces the hand-written ci.yml with a call to the shared workflow, so tests, coverage, binary compatibility, formatting and scaladoc are configured centrally. Same for scalafmt. Also drops the Slack step, which used the archived slatify action.
Checks now run as explicit sbt tasks rather than through the
checkalias, and checkout is unshallow so versionPolicyCheck has a previous version to compare against.Part of evolution-gaming/scala-github-actions#5
Summary by CodeRabbit