Skip to content

Adopt shared Scala CI workflow #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mr-git merged 7 commits into from
Aug 10, 2026
Merged

Adopt shared Scala CI workflow #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c56e0eb
Adopt shared Scala CI workflow
Aug 7, 2026
f5b92b0
Drop unused sbt-coveralls plugin
Aug 7, 2026
495f72e
Collapse blank line left by plugin removal
Aug 7, 2026
ef971f1
Pin shared workflow and drop secrets inherit
Aug 7, 2026
f638723
Re-pin shared workflow to v6.2.0
Aug 7, 2026
6f8f84b
Update CI workflow to use version 6.3.0
mr-git Aug 10, 2026
ed1ad39
Merge branch 'master' into adopt-shared-ci
mr-git Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 5 additions & 43 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,46 +7,8 @@

jobs:
test:

runs-on: ubuntu-latest

strategy:
matrix:
scala:
- 2.13.18
- 3.3.7

steps:
- uses: actions/checkout@v4

- uses: coursier/cache-action@v6

- name: setup Java 17
uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'oracle'
cache: 'sbt'

- name: setup SBT
uses: sbt/setup-sbt@v1

- name: check code ${{ matrix.scala }}
run: sbt ++${{ matrix.scala }} clean check

- name: build ${{ matrix.scala }}
run: sbt ++${{ matrix.scala }} clean coverage test

- name: test coverage
if: success()
env:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
run: sbt ++${{ matrix.scala }} coverageReport coverageAggregate coveralls

- name: slack
uses: homoluctus/slatify@master
if: failure() && github.ref == 'refs/heads/master'
with:
type: ${{ job.status }}
job_name: Build
url: ${{ secrets.SLACK_WEBHOOK }}
uses: evolution-gaming/scala-github-actions/.github/workflows/ci.yml@dde27b9bd793d41d5aacf8fb74403c9de5da1146 # v6.3.0
with:
scala_versions: '["2.13.18", "3.3.7"]'

@coderabbitai coderabbitai Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Test the declared Scala 3.3 cross-build version.

build.sbt declares Scala 3.3.8, but this workflow tests 3.3.7. CI can pass while the supported Scala 3.3.8 target fails. Change this value to 3.3.8.

Proposed fix 
-      scala_versions: '["2.13.18", "3.3.7"]'
+      scala_versions: '["2.13.18", "3.3.8"]'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
scala_versions: '["2.13.18", "3.3.7"]'
scala_versions: '["2.13.18", "3.3.8"]'
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 12, Update the scala_versions matrix entry
to use Scala 3.3.8 instead of 3.3.7, while preserving the existing Scala 2.13.18
value.

# TODO no sbt-scalafmt in this repo, so formatting was never checked

Check warning on line 13 in .github/workflows/ci.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 


See more on https://sonarcloud.io/project/issues?id=evolution-gaming_cassandra-sync&issues=AZ_dt6KQ-Cw_YAOcOptF&open=AZ_dt6KQ-Cw_YAOcOptF&pullRequest=244
scalafmt_check: false
2 changes: 0 additions & 2 deletions project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.4.4")

addSbtPlugin("org.scoverage" % "sbt-coveralls" % "1.3.15")

addSbtPlugin("com.evolution" % "sbt-scalac-opts-plugin" % "0.2.0")

addSbtPlugin("com.evolution" % "sbt-artifactory-plugin" % "0.1.2")
Expand Down