Skip to content

feat(esl-toggleable): make outside action delay configurable for ESLToggleableManager using prop ESLToggleable.prototype.OUTSIDE_ACTION_DELAY#3740

Open
ala-n wants to merge 2 commits intomainfrom
feat/esl-toggleable-outide-delay
Open

feat(esl-toggleable): make outside action delay configurable for ESLToggleableManager using prop ESLToggleable.prototype.OUTSIDE_ACTION_DELAY#3740
ala-n wants to merge 2 commits intomainfrom
feat/esl-toggleable-outide-delay

Conversation

@ala-n
Copy link
Copy Markdown
Collaborator

@ala-n ala-n commented Apr 15, 2026

No description provided.

…oggleableManager using prop ESLToggleable.prototype.OUTSIDE_ACTION_DELAY
@ala-n ala-n requested review from a team April 15, 2026 00:17
@ala-n ala-n self-assigned this Apr 15, 2026
@ala-n ala-n requested review from NastaLeo, Copilot, dshovchko and fshovchko and removed request for a team April 15, 2026 00:17
@qltysh
Copy link
Copy Markdown

qltysh bot commented Apr 15, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.01%.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
packages/esl/src/esl-toggleable/core/esl-toggleable.ts100.0%
Coverage rating: F Coverage rating: F
packages/esl/src/esl-toggleable/core/esl-toggleable-manager.ts0.0%154
Total50.0%
🤖 Increase coverage with AI coding...

In the `feat/esl-toggleable-outide-delay` branch, add test coverage for this new code:

- `packages/esl/src/esl-toggleable/core/esl-toggleable-manager.ts` -- Line 154

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a configurable delay for “outside action” auto-hide behavior in ESLToggleableManager by introducing a new prototype property on ESLToggleable.

Changes:

  • Introduced ESLToggleable.prototype.OUTSIDE_ACTION_DELAY (default 10) to configure outside-interaction hide delay.
  • Updated ESLToggleableManager to use el.OUTSIDE_ACTION_DELAY instead of a hardcoded 10ms delay.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/esl/src/esl-toggleable/core/esl-toggleable.ts Adds new prototype-level configuration property for outside-action hide delay.
packages/esl/src/esl-toggleable/core/esl-toggleable-manager.ts Switches outside-interaction handling to use the new configurable delay.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ala-n ala-n added feature New feature needs review The PR is waiting for review labels Apr 15, 2026
@ala-n ala-n added this to the ⚡ESL: 6.0.0 Major release milestone Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature needs review The PR is waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants