Skip to content

feat(esl-toggleable): make outside action delay configurable for ESLToggleableManager using prop ESLToggleable.prototype.OUTSIDE_ACTION_DELAY #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ala-n wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −2
Open

feat(esl-toggleable): make outside action delay configurable for ESLToggleableManager using prop ESLToggleable.prototype.OUTSIDE_ACTION_DELAY #3740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d83a81
feat(esl-toggleable): make outside action delay configurable for ESLT…
ala-n Apr 15, 2026
a9f0592
style: fix comment from the pull request finding
ala-n Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/esl/src/esl-toggleable/core/esl-toggleable-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ export class ESLToggleableManager {
*/
protected onOutsideInteraction(e: Event, el: ESLToggleable): void {
if (!el.closeOnOutsideAction || !el.isOutsideAction(e)) return;
// Used 10ms delay to decrease priority of the request but positive due to iOS issue
el.hide({initiator: 'outsideaction', hideDelay: 10, event: e});
// Use a delay (10ms by default) to decrease the priority of the request (usually > 0 due to iOS specifics)
el.hide({initiator: 'outsideaction', hideDelay: el.OUTSIDE_ACTION_DELAY, event: e});
}

/** Queues delayed task of the focus management */
Expand Down
3 changes: 3 additions & 0 deletions packages/esl/src/esl-toggleable/core/esl-toggleable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ export class ESLToggleable extends ESLBaseElement {
/** Event to dispatch when toggleable group has changed */
@prop('esl:change:group') public GROUP_CHANGED_EVENT: string;

/** Delay for outside actions to trigger hide. Used by {@link ESLToggleableManager} */
@prop(10) public OUTSIDE_ACTION_DELAY: number;

/**
* CSS class (supports {@link CSSClassUtils}) to add on the body element
* */
Expand Down
Loading