Skip to content

#530: Migrated notebook deployment to Notebook Connector 3.0.0#529

Open
tkilias wants to merge 12 commits into
mainfrom
refactoring/use_new_notebook_connector
Open

#530: Migrated notebook deployment to Notebook Connector 3.0.0#529
tkilias wants to merge 12 commits into
mainfrom
refactoring/use_new_notebook_connector

Conversation

@tkilias

@tkilias tkilias commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the repo-local notebook copy step with Notebook Connectors ai-lab deploy-notebooks during Docker image builds.
  • Remove the work_in_progress_notebooks build path so the image build has one notebook source of truth.
  • Update docs and tests to match the new single-path deployment flow.

Validation

  • poetry run pytest test/unit/test_dss_docker_image.py test/unit/test_run_install_dependencies.py test/unit/test_release_build.py
  • limactl shell default poetry run pytest test/integration/test_create_dss_docker_image.py -k test_install_notebooks -q

Closes #530

@tkilias tkilias temporarily deployed to approve-test-execution June 17, 2026 10:55 — with GitHub Actions Inactive
@tkilias tkilias requested a deployment to approve-gpu-test-execution June 17, 2026 10:55 — with GitHub Actions Waiting
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tkilias tkilias temporarily deployed to approve-aws-ci-execution June 17, 2026 10:56 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to approve-test-execution June 17, 2026 11:28 — with GitHub Actions Inactive
@tkilias tkilias requested a deployment to approve-gpu-test-execution June 17, 2026 11:28 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-aws-ci-execution June 17, 2026 11:30 — with GitHub Actions Waiting
@tkilias tkilias temporarily deployed to approve-test-execution June 17, 2026 11:52 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to approve-gpu-test-execution June 17, 2026 11:52 — with GitHub Actions Inactive
@tkilias tkilias requested a deployment to approve-aws-ci-execution June 17, 2026 11:53 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-gpu-test-execution June 17, 2026 12:54 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-test-execution June 17, 2026 12:54 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-aws-ci-execution June 17, 2026 12:55 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-test-execution June 17, 2026 13:22 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-gpu-test-execution June 17, 2026 13:22 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-aws-ci-execution June 17, 2026 13:23 — with GitHub Actions Waiting
@tkilias tkilias temporarily deployed to approve-test-execution June 17, 2026 14:52 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to approve-gpu-test-execution June 17, 2026 14:52 — with GitHub Actions Inactive
@tkilias tkilias temporarily deployed to approve-aws-ci-execution June 17, 2026 14:53 — with GitHub Actions Inactive
@tkilias tkilias requested a deployment to approve-test-execution June 18, 2026 07:14 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-gpu-test-execution June 18, 2026 07:14 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-aws-ci-execution June 18, 2026 07:15 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-test-execution June 18, 2026 07:30 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-gpu-test-execution June 18, 2026 07:30 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-aws-ci-execution June 18, 2026 07:30 — with GitHub Actions Waiting
@tkilias tkilias deployed to approve-test-execution June 18, 2026 07:44 — with GitHub Actions Active
@tkilias tkilias deployed to approve-gpu-test-execution June 18, 2026 07:44 — with GitHub Actions Active
@tkilias tkilias deployed to approve-aws-ci-execution June 18, 2026 07:45 — with GitHub Actions Active
Comment thread doc/developer_guide/hyperlink-checking.md Outdated
Comment thread doc/developer_guide/notebooks.md Outdated
@tkilias tkilias requested a deployment to approve-test-execution June 18, 2026 11:34 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-gpu-test-execution June 18, 2026 11:34 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-aws-ci-execution June 18, 2026 11:35 — with GitHub Actions Waiting
@tkilias tkilias marked this pull request as ready for review June 18, 2026 11:35
@tkilias tkilias changed the title [codex] deploy notebooks via connector #530: Migrated notebook deployment to Notebook Connector 3.0.0 from PyPI Jun 18, 2026
@tkilias tkilias changed the title #530: Migrated notebook deployment to Notebook Connector 3.0.0 from PyPI #530: Migrated notebook deployment to Notebook Connector 3.0.0 Jun 18, 2026
You can use the command shown below with some limitations:
* Does not support Integrated Exasol Docker-DB.
* Does not allow creating Script Language Containers (SLCs), as is done in the examples in the notebooks [Exporting a flavor](https://github.com/exasol/ai-lab/blob/main/exasol/ds/sandbox/runtime/ansible/roles/jupyter/files/notebook/script_languages_container/export_as_is.ipynb) and [Customizing a flavor](https://github.com/exasol/ai-lab/blob/main/exasol/ds/sandbox/runtime/ansible/roles/jupyter/files/notebook/script_languages_container/customize.ipynb).
* Does not allow creating Script Language Containers (SLCs), as shown in the notebooks "Exporting a flavor" and "Customizing a flavor".

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to have the notebook names? It sounds like these might be sections in them.

The files were export_as_is.ipynb and customize.ipynb

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, the notebook file names are not really relevant for most users, these are the titles of the notebooks and these are more likely to stay. But maybe we remove the reference to specific notebooks and keep it general.

Comment thread doc/developer_guide/notebooks.md Outdated
Comment thread nb_tests.yaml
Co-authored-by: Ariel Schulz <43442541+ArBridgeman@users.noreply.github.com>
@tkilias tkilias requested a deployment to approve-gpu-test-execution June 18, 2026 14:32 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-test-execution June 18, 2026 14:32 — with GitHub Actions Waiting
@tkilias tkilias requested a deployment to approve-aws-ci-execution June 18, 2026 14:33 — with GitHub Actions Waiting
Comment thread nb_tests.yaml
- name: First Steps notebook
test_file: nbtest_first_steps.py
test_backend: onprem
wip: no-wip

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we still have the wip flag.
Can it be removed?

Comment thread nb_tests.yaml
- name: SLC notebook
test_file: nbtest_script_languages_container.py
test_backend: onprem
wip: no-wip

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we still have the wip flag.
Can it be removed?

Comment thread nb_tests.yaml
- name: short notebook tests
test_file: "\"nbtest_environment_test.py nbtest_itde.py\""
test_backend: ''
wip: no-wip

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we still have the wip flag.
Can it be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notebook deployment migration

3 participants