#530: Migrated notebook deployment to Notebook Connector 3.0.0#529
#530: Migrated notebook deployment to Notebook Connector 3.0.0#529tkilias wants to merge 12 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| You can use the command shown below with some limitations: | ||
| * Does not support Integrated Exasol Docker-DB. | ||
| * Does not allow creating Script Language Containers (SLCs), as is done in the examples in the notebooks [Exporting a flavor](https://github.com/exasol/ai-lab/blob/main/exasol/ds/sandbox/runtime/ansible/roles/jupyter/files/notebook/script_languages_container/export_as_is.ipynb) and [Customizing a flavor](https://github.com/exasol/ai-lab/blob/main/exasol/ds/sandbox/runtime/ansible/roles/jupyter/files/notebook/script_languages_container/customize.ipynb). | ||
| * Does not allow creating Script Language Containers (SLCs), as shown in the notebooks "Exporting a flavor" and "Customizing a flavor". |
There was a problem hiding this comment.
Would it be better to have the notebook names? It sounds like these might be sections in them.
The files were export_as_is.ipynb and customize.ipynb
There was a problem hiding this comment.
Hm, the notebook file names are not really relevant for most users, these are the titles of the notebooks and these are more likely to stay. But maybe we remove the reference to specific notebooks and keep it general.
Co-authored-by: Ariel Schulz <43442541+ArBridgeman@users.noreply.github.com>
| - name: First Steps notebook | ||
| test_file: nbtest_first_steps.py | ||
| test_backend: onprem | ||
| wip: no-wip |
There was a problem hiding this comment.
Here we still have the wip flag.
Can it be removed?
| - name: SLC notebook | ||
| test_file: nbtest_script_languages_container.py | ||
| test_backend: onprem | ||
| wip: no-wip |
There was a problem hiding this comment.
Here we still have the wip flag.
Can it be removed?
| - name: short notebook tests | ||
| test_file: "\"nbtest_environment_test.py nbtest_itde.py\"" | ||
| test_backend: '' | ||
| wip: no-wip |
There was a problem hiding this comment.
Here we still have the wip flag.
Can it be removed?
Summary
ai-lab deploy-notebooksduring Docker image builds.work_in_progress_notebooksbuild path so the image build has one notebook source of truth.Validation
poetry run pytest test/unit/test_dss_docker_image.py test/unit/test_run_install_dependencies.py test/unit/test_release_build.pylimactl shell default poetry run pytest test/integration/test_create_dss_docker_image.py -k test_install_notebooks -qCloses #530