-
Notifications
You must be signed in to change notification settings - Fork 0
#530: Migrated notebook deployment to Notebook Connector 3.0.0 #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tkilias
wants to merge
12
commits into
main
Choose a base branch
from
refactoring/use_new_notebook_connector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b2eae85
deploy notebooks via connector
tkilias e2d6ea3
fix notebook ci workflow
tkilias d3138dd
remove hyperlink workflow
tkilias a02ba62
fix notebook artifact naming
tkilias 6265148
restore selected notebook tests
tkilias 2aa8b16
pin ansible apt dependencies
tkilias b2b6574
unpin docker-ce
tkilias 1862606
add changelog entry
tkilias 57134ac
pin notebook connector 3.0.0
tkilias eb21cf1
remove unstable notebooks tests job from github workflow
tkilias 6a4b15c
restore hyperlink workflow
tkilias 48641c7
Update doc/developer_guide/notebooks.md
tkilias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| # Check for Broken Hyperlinks | ||
|
|
||
| AI Lab's GitHub workflow [hyperlinks.yaml](https://github.com/exasol/ai-lab/blob/main/.github/workflows/hyperlinks.yaml) checks the validity of hyperlinks using different tools. | ||
| AI Lab's GitHub workflow [hyperlinks.yaml](https://github.com/exasol/ai-lab/blob/main/.github/workflows/hyperlinks.yaml) checks the validity of hyperlinks in Markdown documentation. | ||
|
|
||
| If a specific link temporarily is unreachable, you can ignore it as specified by the following table. | ||
|
|
||
| | Files | Tool | How to ignore broken links? | | ||
| |-------|------|-----------------------------| | ||
| | Markdown files, e.g. README or Changelog | GitHub action [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) | Add regexp to file `.lycheeignore` | | ||
| | Jupyter notebooks | `pytest --check-links` | Add CLI option `--check-links-ignore <REGEXP>` to the GitHub workflow file | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
exasol/ds/sandbox/runtime/ansible/roles/jupyter/files/jupyter_requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| jupyterlab==4.4.8 | ||
| pexpect==4.8.0 | ||
| jupyterlab >=4.4.8,<5 | ||
| pexpect >=4.8.0,<5 |
1 change: 0 additions & 1 deletion
1
exasol/ds/sandbox/runtime/ansible/roles/jupyter/files/notebook/cloud/.gitignore
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to have the notebook names? It sounds like these might be sections in them.
The files were
export_as_is.ipynbandcustomize.ipynbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, the notebook file names are not really relevant for most users, these are the titles of the notebooks and these are more likely to stay. But maybe we remove the reference to specific notebooks and keep it general.