Add C++17-compatible span wrapper for math module#1155
Open
cdtwigg wants to merge 2 commits into
Open
Conversation
added 2 commits
March 17, 2026 14:42
Summary: Add support for building without C++ exceptions in the common module. - exception.h: Detect whether C++ exceptions are enabled via __cpp_exceptions, __EXCEPTIONS, or _CPPUNWIND. On platforms built with -fno-exceptions, the MT_THROW macros fall back to fprintf(stderr) + abort() instead of throwing. - Split progress_bar into a separate library to allow the common module to build on platforms without terminal I/O headers. Differential Revision: D96328571
Summary: Introduce `momentum::span<T>` type alias that maps to `std::span<T>` on C++20 compilers and `gsl::span<T>` on C++17 compilers. This enables the math module to build on platforms with C++17-only support. - Add math/span_compat.h with C++20 detection and span type alias - Update all math module files to use momentum::span instead of std::span - Fix double-promotion warning in mppca.cpp (0.5 -> T(0.5)) Reviewed By: fantaosha Differential Revision: D96328572
meta-cla
Bot
added
the
CLA Signed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Introduce
momentum::span<T>type alias that maps tostd::span<T>on C++20compilers and
gsl::span<T>on C++17 compilers. This enables the math moduleto build on platforms with C++17-only support.
Reviewed By: fantaosha
Differential Revision: D96328572