Clean up Eigen 5 compiler warnings - #1593
Open
yutingye wants to merge 1 commit into
Open
Conversation
Summary: Update Momentum code for Eigen 5 APIs and clean up compiler warning sites. This moves SVD option selection to the Eigen 5 compile-time form, uses the canonical Euler conversion API, adds explicit error paths for invalid BVH channel enum values, removes stale private declarations that MSVC warns about during explicit template instantiation, and casts Eigen sparse matrix indices before constructing triplets. Differential Revision: D108691805
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@yutingye has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108691805. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Update Momentum code for Eigen 5 APIs and clean up compiler warning sites. This moves SVD option selection to the Eigen 5 compile-time form, uses the canonical Euler conversion API, adds explicit error paths for invalid BVH channel enum values, removes stale private declarations that MSVC warns about during explicit template instantiation, and casts Eigen sparse matrix indices before constructing triplets.
Differential Revision: D108691805