fix(firestore-translate-text): removed unnecessary sanitization#2574
Open
JanKubicek wants to merge 4 commits intofirebase:nextfrom
Open
fix(firestore-translate-text): removed unnecessary sanitization#2574JanKubicek wants to merge 4 commits intofirebase:nextfrom
JanKubicek wants to merge 4 commits intofirebase:nextfrom
Conversation
…onStart event (firebase#2562) * fix(storage-resize-images): add missing recordStartEvent call * feat(storage-resize-images): add onStorageResize event * docs(storage-resize-images): update changelog * chore(storage-resize-images): add onStartResize * chore(storage-resize-images): add onStartResize event --------- Co-authored-by: Tadej <tadej.dev@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Hi, do you have an estimate for when this will be released? |
Member
|
Hey @JanKubicek. This fix works for VertexAI, but for GoogleAI, it's only half of the problem. Unlike VertexAI, GoogleAI's seems to remove the new lines itself when dealing with structured outputs. I'm looking into a fix for this. |
Member
|
One fix is switching from using |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unnecessary text sanitization that caused formatting issues during translation.