Conversation
…texai` Genkit plugins to `google-genai`
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the Genkit plugins from the separate @genkit-ai/googleai and @genkit-ai/vertexai packages to the unified @genkit-ai/google-genai package and updates the genkit dependency to version 1.31.0. A review comment suggests updating the changelog entry to use a colon instead of a dash for better alignment with conventional commit formatting.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes the issue #2573 when merged alongside #2574. From testing, Genkit's
googleaiplugin seems to do some sanitization. I believe this is likely not an issue in the plugin's code, as I couldn't find any sanitization there. This problem likely occurs in the version of the GoogleAI SDK used in thegoogleaiplugin. This PR introducesgoogle-genaiplugin to fix this sanitization problem. Switching to usinggoogle-genaiplugin is also recommended, as it's more up-to-date.Testing: