Skip to content

feat(meta): 新增人工验证完成技能#580

Merged
CodeCasterX merged 1 commit into
mainfrom
agent-infra-feature-manual-validation-complete-skill
Jul 7, 2026
Merged

feat(meta): 新增人工验证完成技能#580
CodeCasterX merged 1 commit into
mainfrom
agent-infra-feature-manual-validation-complete-skill

Conversation

@CodeCasterX

Copy link
Copy Markdown
Contributor

🔗 相关问题 / Related Issue

Issue 链接 / Issue Link: Closes #575 👈👈

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 📦 依赖升级 / Dependency upgrade
  • 🚀 功能增强 / Feature enhancement
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

人工验证完成后,维护者此前需要手动更新 PR 摘要里的人工校验状态,且历史 PR 中出现过摘要状态和额外普通留言并存的表达不统一问题。本次变更新增 complete-manual-validation 技能,让人工验证结果统一写入可追踪产物,并原地更新同一条 PR 摘要评论。

📋 主要变更 / Brief Changelog

  • 新增 complete-manual-validation skill、验证产物模板和中英文部署模板。
  • 新增 Claude Code、Gemini CLI、OpenCode 的命令适配器及模板。
  • 扩展 PR 摘要聚合规则,支持 manual-validation* 产物优先渲染“人工验证已通过”。
  • 扩展 platform-sync gate,支持按配置校验 PR 摘要评论必须包含的 pattern。
  • 补充 platform-sync、PR 摘要规则和命令模板相关测试。

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. npm test
  2. Commit hook: npm run typecheck
  3. Commit hook: npm run test:core

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

N/A

✅ 贡献者检查清单 / Contributor Checklist

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code where needed

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit tests
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 代码检查通过 / Lint checks pass
  • 单元测试通过 / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes

  • PR milestone reuses Issue feat(meta): 新增人工验证完成技能 #575 milestone 0.8.3.
  • 待人工验证:在真实 PR 上执行 complete-manual-validation,确认摘要评论中的 ### ⚠️ 需人工校验 原地更新为 ### ✅ 人工验证已通过,且不会额外创建并行普通留言。

审查者注意事项 / Reviewer Notes:

重点关注 manual-validation* 产物与 PR 摘要聚合之间的持久化边界、platform-sync required pattern 校验是否足够通用,以及中英文模板部署后是否分别使用对应语言的校验标题。

Generated with AI assistance

- Add complete-manual-validation skill and TUI adapters.
- Persist manual validation results for PR summaries.
- Extend platform-sync checks for required PR summary patterns.
- Cover the new PR summary flow with validation tests.

Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@CodeCasterX CodeCasterX added this to the 0.8.3 milestone Jul 7, 2026
@CodeCasterX CodeCasterX added type: feature A general feature in: core Module: core in: templates Module: templates in: meta Module: meta (repo internals / CI / test infra) labels Jul 7, 2026
@CodeCasterX CodeCasterX self-assigned this Jul 7, 2026
@CodeCasterX

CodeCasterX commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

审查摘要

codex · TASK-20260705-161257

更新时间:2026-07-07 18:59:45+08:00

✅ 人工验证已通过

  • 验证时间:2026-07-07 18:59:45+08:00
  • 验证范围:GitHub PR 评论 PATCH 端到端流程;确认 PR feat(meta): 新增人工验证完成技能 #580 的同一条 reviewer 摘要评论可原地更新,且不会额外创建并行普通留言。
  • 验证说明:执行 complete-manual-validation 本身;本技能成功原地更新 <!-- sync-pr:TASK-20260705-161257:summary --> 评论并通过完成校验,因此该人工校验点通过。

关键技术决策

  • 新增 complete-manual-validation skill,而不是一次性手动留言流程;验证结果写入 manual-validation.md / manual-validation-r{N}.md,供后续 PR 摘要刷新复用。
  • 扩展 .agents/rules/pr-sync.md 的人工校验段落为三分支:已通过产物优先,其次需人工校验,最后无需人工校验。
  • 将 PR 摘要正文校验做成 expected_pr_comment_required_patterns 配置,避免把 complete-manual-validation 的标题要求硬编码进平台适配器。
  • 本地运行时使用中文 verify 配置,模板部署提供 en/zh-CN 双语 verify 配置,英文环境校验 ### ✅ Manual Validation Passed

审查历程

轮次 结论 问题统计 修复状态
Round 1 Approved 0 blockers / 0 major / 2 minor / 1 manual-validation 1 minor fixed, 1 minor refuted, manual-validation retained
Round 2 Approved 0 blockers / 0 major / 0 minor / 1 manual-validation AI-actionable findings closed

测试结果

  • npm test passed: 1338 passed, 0 failed, 1 skipped.
  • Commit hook passed: UTF-8 check, version format check, npm run typecheck, inline build freshness, and npm run test:core.
  • Added platform-sync coverage for complete-manual-validation pass/fail PR summary heading cases.

由 codex 自动生成 · 内部追踪:TASK-20260705-161257

@CodeCasterX CodeCasterX merged commit bb5229c into main Jul 7, 2026
12 checks passed
@CodeCasterX CodeCasterX deleted the agent-infra-feature-manual-validation-complete-skill branch July 7, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core Module: core in: meta Module: meta (repo internals / CI / test infra) in: templates Module: templates type: feature A general feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(meta): 新增人工验证完成技能

1 participant