[fix][Python] link name's default value for get* methods.#1118
[fix][Python] link name's default value for get* methods.#1118130s wants to merge 2 commits intofkanehiro:masterfrom
Conversation
775dff3 to
dc5dc55
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
dc5dc55 to
fc022e8
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Did you confirmed if this works with old hrpsys ~= 315.1.x, 315.2.x, |
|
start-jsk/rtmros_hironx#487 (comment) に書いたように下流 Hironx の暫定クラスへのパッチが 315_1_10 のテストが通っていたので大丈夫ではないかということで同 PR は merge 済です. がこの PR の Travis が失敗してますね… |
2回ほど Travis 上の build を見ていますが,どちらも同じ1個の job だけ失敗しているようです." https://s3.amazonaws.com/archive.travis-ci.org/jobs/213581324/log.txt エラーログ見ても原因が分かりません. (14番のテストがおとおりずらくないか? と同じか?と思ったものの,今回しっぱしているのは15番のようなので微妙に違うか.) |
Because `get``{Current, Reference}``{Pose, Position, Rotation, RPY}` methods handle the case where `lname` passed is None in their method's logic, those methods should allow missing `lname`.
[Python] Delegate raising RuntimeError to a common method.
fc022e8 to
71024d3
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Travis も通りました. |
Because
get{Current, Reference}{Pose, Position, Rotation, RPY}methods handle the case wherelnamepassed is None in their method's logic, those methods should also allow the case wherelnameis missing.Also, this PR extracts common portion of procedure when
lnamewas None for better maintenance.