Rename fused_marlin_moe kernels by precision scheme and split benchmarks - #5437
Draft
zeroherolin wants to merge 4 commits into
Draft
Rename fused_marlin_moe kernels by precision scheme and split benchmarks#5437zeroherolin wants to merge 4 commits into
zeroherolin wants to merge 4 commits into
Conversation
zeroherolin
requested review from
0x45f,
103yiran,
Caeruleann,
bin913,
douxetpur,
hellojack163,
huangyiqun,
tengqm and
w1120029931-bit
as code owners
August 13, 2026 03:56
zeroherolin
force-pushed
the
zl_marlin_polish
branch
from
August 13, 2026 04:00
d639960 to
8292034
Compare
Vincent-Xiao
marked this pull request as draft
August 13, 2026 08:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Operator | OP Test | Benchmark
Type of Change
Refactor
Description
Standardize
fused_marlin_moenaming tofused_marlin_moe_<weight-act scheme>_<format>and split the benchmark by precision. Pure rename — no logic change, no new comments.Kernels / entries / tune keys (
src/flag_gems/fused/fused_marlin_moe.py+ runtime registrations):fused_moe_w4a16_gptqfused_marlin_moe_w4a16_int4fused_moe_mxfp4fused_marlin_moe_w4a16_mxfp4_w4a16_*/_mxfp4_*kernels & invokes_w4a16_int4_*/_w4a16_mxfp4_*w4a16_pack/mxfp4_packw4a16_int4_pack/w4a16_mxfp4_packfused_marlin_moe_mxfp4[_gemm_silu]fused_marlin_moe_w4a16_mxfp4[_gemm_silu]INT8 (
w8a16_int8) reuses the generic wna16 fallback and has no dedicated kernel;w8a16_fp8is reserved for future work.Tests (
tests/test_fused_marlin_moe.py): test functions renamed totest_fused_marlin_moe_{w4a16_int4, w8a16_int8, w4a16_mxfp4}.Benchmark:
benchmark/test_fused_marlin_moe.pysplit into three self-contained per-precision files (test_fused_marlin_moe_{w4a16_int4, w8a16_int8, w4a16_mxfp4}.py), following thetest_fused_moe_<precision>.pyconvention; pytest marker unified tofused_marlin_moe.Issue
N/A
Progress
Performance
No perf impact expected (identifier-only rename). Verified on H20 (sm90): 119 unit tests collected, per-precision subset + guard tests all pass; renamed tune keys load correctly via libtuner.