Skip to content

Re-register all users for push notifications with new keys when upgrading to Mobile SDK 13 - #2751

Merged
wmathurin merged 2 commits into
forcedotcom:devfrom
wmathurin:unexpected_logout
Aug 28, 2025
Merged

Re-register all users for push notifications with new keys when upgrading to Mobile SDK 13#2751
wmathurin merged 2 commits into
forcedotcom:devfrom
wmathurin:unexpected_logout

Conversation

@wmathurin

@wmathurin wmathurin commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Without this, an application will not be able to decrypt encrypted push notifications if:

…ding to Mobile SDK 13.0.

Without this, an application will not be able to decrypt encrypted push notifications if:
- it was first installed with Mobile SDK 11.x or older
- it has elected to disable re-registration entirely
@github-actions

github-actions Bot commented Aug 28, 2025

Copy link
Copy Markdown
1 Warning
⚠️ libs/SalesforceSDK/src/com/salesforce/androidsdk/app/SalesforceSDKUpgradeManager.java#L152 - Consider using apply() instead; commit writes its data to persistent storage immediately, whereas apply will handle it in the background

Generated by 🚫 Danger

@codecov

codecov Bot commented Aug 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.11%. Comparing base (19fa711) to head (0b03084).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #2751   +/-   ##
=========================================
  Coverage     56.11%   56.11%           
- Complexity     2492     2493    +1     
=========================================
  Files           211      211           
  Lines         17255    17259    +4     
  Branches       2412     2413    +1     
=========================================
+ Hits           9682     9685    +3     
- Misses         6523     6524    +1     
  Partials       1050     1050           
Components Coverage Δ
Analytics 47.92% <ø> (ø)
SalesforceSDK 43.87% <100.00%> (+0.01%) ⬆️
Hybrid 58.05% <ø> (ø)
SmartStore 78.20% <ø> (ø)
MobileSync 79.23% <ø> (ø)
React 46.94% <ø> (ø)
Files with missing lines Coverage Δ
...ce/androidsdk/app/SalesforceSDKUpgradeManager.java 44.29% <100.00%> (+1.53%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wmathurin
wmathurin merged commit b2aa153 into forcedotcom:dev Aug 28, 2025
18 checks passed
wmathurin added a commit to wmathurin/SalesforceMobileSDK-Android that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants