Skip to content

Re-register all users for push notifications with new keys when upgrading to Mobile SDK 13 #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmathurin merged 2 commits into from
Aug 28, 2025
Merged

Re-register all users for push notifications with new keys when upgrading to Mobile SDK 13 #2751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1837936
Re-register all users for push notifications with new keys when upgra…
wmathurin Aug 28, 2025
0b03084
Fixing test / adding new tests
wmathurin Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libs/SalesforceSDK/src/com/salesforce/androidsdk/app/SalesforceSDKUpgradeManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ else if (installedVersion.isGreaterThanOrEqualTo(new SdkVersion(9, 2, 0, false))
if (installedVersion.isLessThan(new SdkVersion(12, 0, 0, false))) {
updateFromBefore12_0_0();
}
if (installedVersion.isLessThan(new SdkVersion(13, 0, 2, false))) {
updateFromBefore13_0_2();
}
if (installedVersion.isLessThan(new SdkVersion(15, 0, 0, false))) {
migrateAccountType();
}
Expand Down Expand Up @@ -306,6 +309,10 @@ private void updateFromBefore12_0_0() {
PushMessaging.setReRegistrationRequested(true);
}

private void updateFromBefore13_0_2() {
// Re-register all users for push notifications with new keys once push is setup
PushMessaging.setReRegistrationRequested(true);
}

/*
* Migrate any accounts with account_type "com.salesforce.androidsdk" to a unique value.
Expand Down
19 changes: 17 additions & 2 deletions ...st/SalesforceSDKTest/src/com/salesforce/androidsdk/app/SalesforceSDKUpgradeManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,24 @@ class SalesforceSDKUpgradeManagerTest {
}

@Test
fun testUpgradeAfter12() {
fun testUpgradeFromBefore1302() {
// Set version to a version before 13.0.2
setVersion("12.2.0")

// Create public key for push notifications
KeyStoreWrapper.getInstance().getRSAPublicString(PushService.pushNotificationKeyName)

// Upgrade to latest
upgradeMgr.upgrade()

// Make sure re-registration is requested
Assert.assertTrue(PushMessaging.reRegistrationRequested)
}

@Test
fun testUpgradeAfter1302() {
// Set version to 12.0.0
setVersion("12.0.0")
setVersion("13.0.2")

// Create public key for push notifications
KeyStoreWrapper.getInstance().getRSAPublicString(PushService.pushNotificationKeyName)
Expand Down