Skip to content

[iOS] Fix QR Code Login Flow to Bypass shouldAuthenticate Check When Using frontDoorBridgeUrl #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crebs merged 1 commit into from
Jul 29, 2025
Merged

[iOS] Fix QR Code Login Flow to Bypass shouldAuthenticate Check When Using frontDoorBridgeUrl #3894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Util/SFSDKAuthHelper.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ + (void)loginIfRequired:(UIScene *)scene
}
}];

if ([self isDeepLink:loginHint host:loginHost] || [self shouldAuthenticateNewUser]) {
if (frontDoorBridgeUrl || [self isDeepLink:loginHost] || [self shouldAuthenticateNewUser]) {
SFUserAccountManagerFailureCallbackBlock failureBlock = ^(SFOAuthInfo *authInfo, NSError *authError) {
[SFSDKCoreLogger e:[self class] format:@"Authentication failed: %@.", [authError localizedDescription]];
};
Expand Down Expand Up @@ -114,8 +114,8 @@ + (void)loginIfRequired:(UIScene *)scene
}
}

+ (BOOL)isDeepLink:(NSString *)hint host:(NSString *)host {
return ([hint length] > 0 && [host length] > 0);
+ (BOOL)isDeepLink:(NSString *)host {
return [host length] > 0;
}

+ (BOOL)shouldAuthenticateNewUser {
Expand Down
Loading