Skip to content

Moving to SQLCipher 4.10.0 - #3898

Merged
wmathurin merged 10 commits into
forcedotcom:devfrom
wmathurin:sqlcipher410
Aug 19, 2025
Merged

Moving to SQLCipher 4.10.0#3898
wmathurin merged 10 commits into
forcedotcom:devfrom
wmathurin:sqlcipher410

Conversation

@wmathurin

@wmathurin wmathurin commented Aug 16, 2025

Copy link
Copy Markdown
Contributor

Important, only merge after:

Notable changes:

  • The SmartStore project now gets FMDB and SQLCipher via SPM
  • We no longer have a submodule for FMDB
  • We no longer (build and) check in SQLCipher.xcframework in this repo

I also modified update_podspecs_headers.sh:

  • in the past, when there was a exclude_files in the pod spec, then the public headers were sorted
  • now, we always sort the public headers - as a result in this PR, all the pod specs have changed

NB: we are getting FMDB Swift package from our (updated) fork - for more details see: forcedotcom/fmdb#15

/* Begin XCRemoteSwiftPackageReference section */
4FC72E662E500C7100A8AA8D /* XCRemoteSwiftPackageReference "fmdb" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/wmathurin/fmdb";

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: will switch that to forcedotcom/fmdb once forcedotcom/fmdb#15 gets merged

@github-actions

Copy link
Copy Markdown
1 Warning
⚠️ Big PR, try to keep changes smaller if you can.

Generated by 🚫 Danger

@codecov

codecov Bot commented Aug 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.06%. Comparing base (6b9abc9) to head (ec2d7a0).
⚠️ Report is 14 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3898   +/-   ##
=======================================
  Coverage   63.06%   63.06%           
=======================================
  Files         251      251           
  Lines       22467    22467           
=======================================
  Hits        14168    14168           
  Misses       8299     8299           
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 70.58% <ø> (ø)
Core 53.21% <ø> (ø)
SmartStore 73.66% <ø> (ø)
MobileSync 87.66% <ø> (ø)
Files with missing lines Coverage Δ
...tore/SmartStore/Classes/SFAlterSoupLongOperation.m 93.50% <ø> (ø)
libs/SmartStore/SmartStore/Classes/SFSmartStore.m 81.31% <ø> (ø)
...e/SmartStore/Classes/SFSmartStoreDatabaseManager.m 66.87% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Also adding SQLCipher as a package dependency for SmartStore even though it's coming through our forked FMDB also - that way we control the exact version to depend on
@wmathurin
wmathurin marked this pull request as ready for review August 19, 2025 21:51
@wmathurin
wmathurin requested a review from bbirman August 19, 2025 22:05
Comment thread .github/workflows/pr.yaml
jobs:
static-analysis:
runs-on: macos-15
runs-on: macos-16

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that might fixed the static analysis but it did not help

@wmathurin

Copy link
Copy Markdown
Contributor Author

The main gain from this PR:
Screenshot 2025-08-19 at 3 07 06 PM

@wmathurin

Copy link
Copy Markdown
Contributor Author

Tests are passing but static analysis is failing (already in previous PRs).

@wmathurin
wmathurin merged commit 0bee96a into forcedotcom:dev Aug 19, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants