Moving to SQLCipher 4.10.0 - #3898
Merged
Merged
Conversation
NB: SmartStore now gets SQLCipher and FMDB via SPM
wmathurin
commented
Aug 16, 2025
| /* Begin XCRemoteSwiftPackageReference section */ | ||
| 4FC72E662E500C7100A8AA8D /* XCRemoteSwiftPackageReference "fmdb" */ = { | ||
| isa = XCRemoteSwiftPackageReference; | ||
| repositoryURL = "https://github.com/wmathurin/fmdb"; |
Contributor
Author
There was a problem hiding this comment.
NB: will switch that to forcedotcom/fmdb once forcedotcom/fmdb#15 gets merged
Generated by 🚫 Danger |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3898 +/- ##
=======================================
Coverage 63.06% 63.06%
=======================================
Files 251 251
Lines 22467 22467
=======================================
Hits 14168 14168
Misses 8299 8299
🚀 New features to boost your workflow:
|
Also adding SQLCipher as a package dependency for SmartStore even though it's coming through our forked FMDB also - that way we control the exact version to depend on
wmathurin
marked this pull request as ready for review
August 19, 2025 21:51
wmathurin
commented
Aug 19, 2025
| jobs: | ||
| static-analysis: | ||
| runs-on: macos-15 | ||
| runs-on: macos-16 |
Contributor
Author
There was a problem hiding this comment.
I thought that might fixed the static analysis but it did not help
Contributor
Author
bbirman
approved these changes
Aug 19, 2025
Contributor
Author
|
Tests are passing but static analysis is failing (already in previous PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important, only merge after:
Notable changes:
I also modified update_podspecs_headers.sh:
NB: we are getting FMDB Swift package from our (updated) fork - for more details see: forcedotcom/fmdb#15