feat(W-23201582): surface App Attestation state in developer info screen - #4123
Merged
wmathurin merged 3 commits intoAug 7, 2026
Merged
Conversation
Appends an "App Attestation" section to getDevSupportInfos() with two rows: - Attestation Enabled (YES/NO from UserAccountManager.appAttestationEnabled) - Feature Flag (AA) (YES/NO from kSFAppFeatureAppAttestation per-user flag, N/A if no user) Adds four unit tests in DevInfoViewControllerTests covering the section structure and all YES/NO/N/A combinations.
Clang Static Analysis Issues
Generated by 🚫 Danger |
|
||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4123 +/- ##
==========================================
- Coverage 71.35% 67.18% -4.18%
==========================================
Files 254 254
Lines 22557 22570 +13
==========================================
- Hits 16095 15163 -932
- Misses 6462 7407 +945
🚀 New features to boost your workflow:
|
|
||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDevSupportInfos()inSalesforceSDKManager.m, placed after the existing RTR section[SFUserAccountManager sharedInstance].appAttestationEnabledkSFAppFeatureAppAttestationper-user feature flag; N/A if no user is logged inTests
Added 4 unit tests in
DevInfoViewControllerTests.swiftvia the existingtestExtractSectionshelper:testAppAttestationSection_DisabledNoUser— Attestation Enabled: NO, Feature Flag: N/AtestAppAttestationSection_DisabledWithUser_NoFlag— Attestation Enabled: NO, Feature Flag: NOtestAppAttestationSection_EnabledWithFeatureFlag— Attestation Enabled: YES, Feature Flag: YEStestAppAttestationSection_AppearsAfterRtrSection— verifies section order (RTR then App Attestation)Related