fix(upnp): bound discovery and SOAP request time - #666
Open
colinaumaty wants to merge 1 commit into
Open
Conversation
Signed-off-by: colinaumaty <colinaumaty@outlook.com>
colinaumaty
force-pushed
the
feature_colinaumaty
branch
from
September 1, 2026 16:39
a1a4f96 to
67211e2
Compare
Contributor
|
Why 3 seconds, and can you make the value a constant so we can tune it easier in the future? I would go with 5 or 10 seconds. Still fixes the blocking, but gives a bit more time for slow equipment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPnP discovery and SOAP calls now share a three-second HTTP timeout, preventing a non-responsive router from blocking discovery indefinitely while preserving the normal success path.