Skip to content

fix(upnp): bound discovery and SOAP request time #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colinaumaty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(upnp): bound discovery and SOAP request time #666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions upnp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ import (
"time"
)

var upnpHTTPClient = &http.Client{Timeout: 3 * time.Second}

// NAT is an interface representing a NAT traversal options for example UPNP or
// NAT-PMP. It provides methods to query and manipulate this traversal to allow
// access to services.
Expand Down Expand Up @@ -223,7 +225,7 @@ func getOurIP() (ip string, err error) {
// getServiceURL parses the xml description at the given root url to find the
// url for the WANIPConnection service to be used for port forwarding.
func getServiceURL(rootURL string) (url string, err error) {
r, err := http.Get(rootURL)
r, err := upnpHTTPClient.Get(rootURL)
if err != nil {
return
}
Expand Down Expand Up @@ -304,7 +306,7 @@ func soapRequest(url, function, message string) (replyXML []byte, err error) {
req.Header.Set("Cache-Control", "no-cache")
req.Header.Set("Pragma", "no-cache")

r, err := http.DefaultClient.Do(req)
r, err := upnpHTTPClient.Do(req)
if err != nil {
return nil, err
}
Expand Down