Return an error when a tensor's name in gguf is long#657
Open
ReinforcedKnowledge wants to merge 2 commits intoggml-org:masterfrom
Open
Return an error when a tensor's name in gguf is long#657ReinforcedKnowledge wants to merge 2 commits intoggml-org:masterfrom
ReinforcedKnowledge wants to merge 2 commits intoggml-org:masterfrom
Conversation
Author
|
This is a very small PR but as I'm trying to write blip2 in C/C++ using on GGML, I find that having an error here would have helped me find the issue with my GGUF file quicker. |
ggerganov
reviewed
Dec 19, 2023
Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When writing a GGUF file, there are very few checks that are made but that could cause an error when loading and working with it. One of them is having tensor names that are longer than 64 characters.
The name of a tensor when reading tensor information doesn't have a limit of characters on it as we can see here
gguf_tensor_infobut when later on we work with the GGML tensors we find that there is indeed a limit which can cause an issue when looking up a tensor by its name.Changes Made
This PR concerns
gguf_init_from_file.