Skip to content

Return an error when a tensor's name in gguf is long #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ReinforcedKnowledge wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −0
Open

Return an error when a tensor's name in gguf is long #657

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22ae5ed
Add error when a tensor's name in gguf is long
ReinforcedKnowledge Dec 16, 2023
34dc1bf
Reuse code logic in the error
ReinforcedKnowledge Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ggml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18640,6 +18640,13 @@ struct gguf_context * gguf_init_from_file(const char * fname, struct gguf_init_p
}

ok = ok && gguf_fread_str(file, &info->name, &offset);
if (strlen(info->name.data) > GGML_MAX_NAME - 1) {
fprintf(stderr, "%s: tensor name '%s' is too long (maximum length: %d characters)\n", __func__, info->name.data, GGML_MAX_NAME - 1);
fclose(file);
gguf_free(ctx);
return NULL;
}

ok = ok && gguf_fread_el (file, &info->n_dims, sizeof(info->n_dims), &offset);
for (uint32_t j = 0; j < info->n_dims; ++j) {
ok = ok && gguf_fread_el(file, &info->ne[j], sizeof(info->ne[j]), &offset);
Expand Down