Fix Smoke Pi: no safe outputs due to wrong prompt order and missing gh CLI instruction#38719
Merged
pelikhan merged 3 commits intoJun 11, 2026
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Smoke Pi issue with no safe outputs produced
Fix Smoke Pi: no safe outputs due to wrong prompt order and missing gh CLI instruction
Jun 11, 2026
pelikhan
deleted the
copilot/copilotdelete-legacy-files-model-multipliers
branch
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Smoke Pi producing no safe outputs by ensuring the assembled Pi prompt order matches intent (task instructions first, end-of-body reminders last) and by updating the first test to use gh instead of unavailable GitHub MCP tooling in gh-proxy mode.
Changes:
- Update Smoke Pi test 1 to use
ghCLI to fetch two merged PRs (title + number). - Inline
noop-remindercontent so it stays at the end of the workflow body after runtime import handling. - Recompile
smoke-pi.lock.ymlto remove the promoted pre-bodynoop-reminderimport.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/smoke-pi.md | Adjusts test instructions to use gh and inlines the noop reminder to preserve intended end-of-body ordering. |
| .github/workflows/smoke-pi.lock.yml | Updates compiled prompt assembly so noop-reminder is no longer promoted ahead of the workflow body. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
+105
to
+109
| **Important**: If no action is needed after completing your analysis, you **MUST** call the `noop` safe-output tool with a brief explanation. Pass arguments directly to the tool. Do **NOT** wrap them under a `noop` key. Failing to call any safe-output tool is the most common cause of safe-output workflow failures. | ||
|
|
||
| ```json | ||
| {"message": "No action needed: [brief explanation of what was analyzed and why]"} | ||
| ``` No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoke Pi produced no safe outputs because the Pi engine received contradictory/misordered instructions in its assembled prompt.
Root causes
1.
noop-reminderpromoted before task instructions{{#runtime-import shared/noop-reminder.md}}at the end of the workflow body was being extracted byExtractBodyLevelImportPathsand promoted to a top-level import chunk beforesmoke-pi.mdin the compiled lock file. Runtime deduplication then skipped the directive at its intended end-of-body position, so the agent read "call noop if no action needed" before "ALWAYS create an issue" — with no repetition at the end.Before (lock file prompt order):
After:
2. Test 1 referenced unavailable GitHub MCP tools
Test 1 instructed "Use GitHub MCP tools…" but Pi requires
mode: gh-proxy, andcli_proxy_with_safeoutputs_prompt.mdexplicitly states: "No GitHub MCP server is available;ghis your only way to read from GitHub."Changes
smoke-pi.md: Replace{{#runtime-import shared/noop-reminder.md}}with inlined content so the reminder stays at the end of the body after runtime import expansion. Change test 1 from "Use GitHub MCP tools" → "UseghCLI commands".smoke-pi.lock.yml: Recompiled —noop-reminder.mdno longer appears as a separate pre-body import.