refactor(staker): optimize reward calculation in warmup loop

[aronpark1007]

Summary

• Remove redundant zero initialization in RewardState — make([]int64, n) already zero-initializes
• Cache CurrentTick result per warmup iteration instead of querying the same value twice
• Cache raw reward at each warmup boundary and reuse as the next iteration's start basis, reducing CalculateRawRewardForPosition calls per warmup

Test Plan

No new tests required. Existing tests cover all changes:

remove redundant zero initialization in RewardState
TestRewardStateOf — confirms slice length is correct after construction

cache CurrentTick per warmup iteration
TestCanonicalWarmup_1 — verifies per-tier reward accuracy one block at a time

cache raw reward at warmup boundary to reduce ReverseIterate calls
TestCanonicalWarmup_2 — AssertEmulatedRewardOf called once after 40 blocks, exercises startRaw carry-forward across all 4 warmup boundaries in a single rewardPerWarmup call

TestHistoricalTickDensity_DoesNotChangeRewardCalculation — covers tick crossing combined with warmup accumulator

Summary by CodeRabbit

• Refactor
  • Optimized reward calculation logic in staking pools to improve performance through streamlined computation methods.

[coderabbitai]

Walkthrough

Modified reward calculation logic in reward_calculation_pool.gno: removed explicit zero-initialization loops and replaced per-segment reward computation with incremental computation that maintains state across warmup segments, performing subtraction at the raw-reward level.

Changes

Cohort / File(s)	Summary
Reward Calculation Optimization contract/r/gnoswap/staker/v1/reward_calculation_pool.gno	Refactored rewardPerWarmup method to compute rewards incrementally across warmup segments rather than per-segment; removed explicit initialization loops; moved subtraction operation to raw-reward level before liquidity scaling.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main optimization: reducing computation in the warmup loop's reward calculation logic through caching and elimination of redundant operations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/staker-reward-optimization

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud