Skip to content

refactor(staker): optimize reward calculation in warmup loop #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aronpark1007 wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −19
Open

refactor(staker): optimize reward calculation in warmup loop #1268

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
665b7b7
refactor(staker): remove redundant zero initialization in RewardState
aronpark1007 Apr 21, 2026
0738ba5
refactor(staker): cache CurrentTick per warmup iteration
aronpark1007 Apr 21, 2026
2cf76ba
refactor(staker): cache raw reward at warmup boundary to reduce Rever…
aronpark1007 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 11 additions & 19 deletions contract/r/gnoswap/staker/v1/reward_calculation_pool.gno
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,6 @@ func (self *PoolResolver) RewardStateOf(deposit *sr.Deposit) *RewardState {
penalties: make([]int64, warmups),
}

for i := range result.rewards {
result.rewards[i] = 0
result.penalties[i] = 0
}

return result
}

Expand Down Expand Up @@ -406,20 +401,19 @@ func (self *RewardState) rewardPerWarmup(startTime, endTime int64, rewardPerSeco
return nil
}

startTick := self.pool.CurrentTick(startTime)
startRaw := self.pool.CalculateRawRewardForPosition(startTime, startTick, self.deposit.Deposit)

for i, warmup := range self.deposit.Warmups() {
if startTime >= warmup.NextWarmupTime {
// passed the warmup
continue
}

if endTime < warmup.NextWarmupTime {
rewardAcc := self.pool.CalculateRewardForPosition(
startTime,
self.pool.CurrentTick(startTime),
endTime,
self.pool.CurrentTick(endTime),
self.deposit.Deposit,
)
endTick := self.pool.CurrentTick(endTime)
endRaw := self.pool.CalculateRawRewardForPosition(endTime, endTick, self.deposit.Deposit)
rewardAcc := u256.Zero().Sub(endRaw, startRaw)

rewardAcc = u256.Zero().Mul(rewardAcc, self.deposit.Liquidity())
rewardAcc = u256.MulDiv(rewardAcc, u256.NewUintFromInt64(rewardPerSecond), q128)
Expand All @@ -428,19 +422,17 @@ func (self *RewardState) rewardPerWarmup(startTime, endTime int64, rewardPerSeco
break
}

rewardAcc := self.pool.CalculateRewardForPosition(
startTime,
self.pool.CurrentTick(startTime),
warmup.NextWarmupTime,
self.pool.CurrentTick(warmup.NextWarmupTime),
self.deposit.Deposit,
)
endTick := self.pool.CurrentTick(warmup.NextWarmupTime)
endRaw := self.pool.CalculateRawRewardForPosition(warmup.NextWarmupTime, endTick, self.deposit.Deposit)
rewardAcc := u256.Zero().Sub(endRaw, startRaw)

rewardAcc = u256.Zero().Mul(rewardAcc, self.deposit.Liquidity())
rewardAcc = u256.MulDiv(rewardAcc, u256.NewUintFromInt64(rewardPerSecond), q128)
self.rewards[i] = safeAddInt64(self.rewards[i], safeConvertToInt64(rewardAcc))

startTime = warmup.NextWarmupTime
startTick = endTick
startRaw = endRaw
}

return nil
Expand Down
Loading