Skip to content

balancer/ringhash: fix uint32 weight sum overflow in normalizeWeights - #9357

Open
nvxbug wants to merge 2 commits into
grpc:masterfrom
nvxbug:ringhash-weight-sum-overflow
Open

balancer/ringhash: fix uint32 weight sum overflow in normalizeWeights#9357
nvxbug wants to merge 2 commits into
grpc:masterfrom
nvxbug:ringhash-weight-sum-overflow

balancer/ringhash: address review comments

d55cb28
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 30, 2026 in 1s

87.55% (+0.12%) compared to 4793ad0

View this Pull Request on Codecov

87.55% (+0.12%) compared to 4793ad0

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.55%. Comparing base (4793ad0) to head (d55cb28).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9357      +/-   ##
==========================================
+ Coverage   87.42%   87.55%   +0.12%     
==========================================
  Files         424      429       +5     
  Lines       30283    30622     +339     
==========================================
+ Hits        26476    26812     +336     
- Misses       3806     3809       +3     
  Partials        1        1              
Files with missing lines Coverage Δ
balancer/ringhash/ring.go 100.00% <100.00%> (ø)

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.