ci: actually run the Zeitwerk check

[dkastl]

The Zeitwerk check step in test-postgis.yml has never run.

It is guarded by:

if grep -q zeitwerk config/application.rb ; then
  bundle exec rake zeitwerk:check
fi

config/application.rb does not mention Zeitwerk in any supported Redmine version. Redmine configures it in config/initializers/zeitwerk.rb, so the grep always fails and the step exits 0 without doing anything.

Evidence: on the most recent run, the "Zeitwerk check" step is green with zero log output — no "Hold on, I am eager loading the application", no "All is good!". A step that reports success without running is worse than no step, because the repository looks covered.

Why it matters

Test and development environments have eager_load = false; production has it true. So a filename/constant mismatch that nothing references at boot passes every test and then kills a production instance at startup with a NameError.

Not hypothetical: redmine_gtt_sync shipped exactly this bug. Its CI was green on Redmine 6.1 and 7.0 while every production image built over almost four weeks failed to boot (uninitialized constant RedmineGttSync::Oauth). Running this task reproduces that failure, so an active gate would have caught it the day it landed.

The change

Drop the guard and run the task unconditionally. It ships with Rails 6+, so every row in this matrix has it; the guard protected against nothing.

Verified against Redmine 7.0.0 / Ruby 4.0.6 with this plugin installed alongside nine others: rake zeitwerk:check reports "All is good!", so this should not turn the matrix red. If a row does fail, that is a real latent bug worth surfacing.

Companion changes apply the same fix to redmine_gtt_fiware (identical dead guard) and add the step to redmine_custom (missing entirely).

[Copilot]

Pull request overview

This PR fixes a false-positive CI signal by ensuring the Rails Zeitwerk autoloading check actually runs in the PostGIS test workflow, so constant/file mismatches are caught during CI rather than surfacing only in production eager-load boots.

Changes:

• Removes the ineffective grep-based guard that prevented zeitwerk:check from running.
• Runs bundle exec rake zeitwerk:check unconditionally in the Redmine working directory.
• Adds inline workflow documentation explaining why the check matters and why the guard was incorrect.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.