Skip to content

ci: actually run the Zeitwerk check #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkastl merged 1 commit into from
Jul 29, 2026
+11 −5
Merged

ci: actually run the Zeitwerk check #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/test-postgis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,21 @@ jobs:
bundle exec rake generate_secret_token
bundle exec rake db:create db:migrate redmine:plugins:migrate

# Eager-load gate. Test and development environments load lazily, so a
# filename/constant mismatch nothing references at boot can still make a
# production instance (which eager loads) die with a NameError. That is
# what happened to redmine_gtt_sync: green CI, unbootable production.
#
# This previously ran only `if grep -q zeitwerk config/application.rb`,
# which never matches: Redmine configures Zeitwerk in
# config/initializers/zeitwerk.rb, not application.rb. The step therefore
# passed without ever running the task. The rake task ships with Rails 6+,
# so every row in this matrix has it and no guard is needed.
- name: Zeitwerk check
env:
RAILS_ENV: test
working-directory: redmine
run: |
if grep -q zeitwerk config/application.rb ; then
bundle exec rake zeitwerk:check
fi
shell: bash
run: bundle exec rake zeitwerk:check

- name: Run tests
env:
Expand Down